Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rules for Rules section #3703

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Sep 21, 2024

Issue #, if available:
#3630

Description of changes:

  • Add rules for Rules section

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 98.46154% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.69%. Comparing base (d44b32f) to head (b319a6f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/cfnlint/template/template.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3703      +/-   ##
==========================================
+ Coverage   93.67%   93.69%   +0.02%     
==========================================
  Files         359      362       +3     
  Lines       12270    12331      +61     
  Branches     2631     2631              
==========================================
+ Hits        11494    11554      +60     
  Misses        429      429              
- Partials      347      348       +1     
Flag Coverage Δ
unittests 93.64% <98.46%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit cf66b46 into aws-cloudformation:main Sep 23, 2024
22 checks passed
@kddejong kddejong deleted the feature/rules/rules branch September 23, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant